Move bullet rate validation to server to prevent cheating

halftheopposite · Oct 23, 2019 · 3b951fb · 3b951fb
1 parent 19a2515
commit 3b951fb
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/packages/client/src/managers/GameManager.ts b/packages/client/src/managers/GameManager.ts
@@ -247,7 +247,6 @@ export default class GameManager {
 
     this.onActionSend({
       type: 'move',
-      ts: Date.now(),
       value: {
         x: dir.x,
         y: dir.y,
@@ -291,7 +290,6 @@ export default class GameManager {
         this.me.rotation = rotation;
         this.onActionSend({
           type: 'rotate',
-          ts: Date.now(),
           value: {
             rotation,
           },
@@ -303,7 +301,6 @@ export default class GameManager {
         this.me.rotation = this.forcedRotation;
         this.onActionSend({
           type: 'rotate',
-          ts: Date.now(),
           value: {
             rotation: this.forcedRotation,
           },
@@ -332,7 +329,6 @@ export default class GameManager {
     );
     this.onActionSend({
       type: 'shoot',
-      ts: Date.now(),
       value: {
         angle: this.me.rotation,
       },

diff --git a/packages/common/src/types.ts b/packages/common/src/types.ts
@@ -13,7 +13,7 @@ export type MapNameType = 'small' | 'long' | 'big';
 
 export interface IAction {
   playerId?: string;
-  ts: number;
+  ts?: number;
   type: ActionType;
   value: any;
 }

diff --git a/packages/server/src/rooms/DMRoom.ts b/packages/server/src/rooms/DMRoom.ts
@@ -53,6 +53,7 @@ export class DMRoom extends Room<DMState> {
         this.state.playerAddAction({
           playerId,
           ...data,
+          ts: Date.now(),
         });
         break;
       default: