Skip to content

fix(vendor): enforce native customer form validation - #245

Merged
hamidreza1394 merged 2 commits into
mainfrom
fix/vendor-customer-native-validation
Oct 29, 2026
Merged

hamidreza1394 merged 2 commits into
mainfrom
fix/vendor-customer-native-validation

Conversation

@hamidreza1394

Copy link
Copy Markdown
Owner

Summary

  • Add a regression test asserting the commercial customer form does not disable native browser constraint validation.
  • Remove noValidate so required and maxLength constraints are enforced by the browser before the submit handler runs.

Scope

  • Vendor React UI and its unit test only.
  • No API, database, migration, customer accounting module, or credential-handling changes.

Verification

  • Test-first change: regression assertion committed before the form fix.
  • GitHub Actions must pass before merge; local test execution is not available in this environment.

Related: PR #244 fixes the same validation defect in the provisioning request form.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fd250f8f-c44a-4277-9246-bb72ae6a4cb9
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hamidreza1394
hamidreza1394 merged commit 381201b into main Oct 29, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant