Generate command automatic slice detection (and a working test) #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a little spike for you, @krzykamil :)
As you discovered, in-memory
fsobject was mostly just getting in the way of writing an effective test. So in this case I avoided it altogether, and let actual files get written to disk.The result is we don't have any stubbing at all, so we exercise real code from top to bottom.
Let me know what you think :) Happy to chat further, and of course, I'm happy for you to take this code take it in whatever direction you need to finish the feature. At minimum, we're definitely missing some tests.
(Follows on from #298)