Make slice sampling work standalone #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjameshandley
requested changes
Oct 15, 2025
williamjameshandley
left a comment
williamjameshandley
left a comment
There was a problem hiding this comment.
This is a great idea.
Could we add some tests/examples on actually running a slice sampler on its own?
| """ | ||
| return SliceState(position, logdensity_fn(position), constraint_fn(position)) | ||
| logp = logdensity_fn(position) | ||
| constraint_val = (constraint_fn or (lambda _: jnp.array([])))(position) |
There was a problem hiding this comment.
Is this the blackjaxy way to do it, or should this default go at line 92?
| def build_hrss_kernel( | ||
| generate_slice_direction_fn: Callable, | ||
| stepper_fn: Callable, | ||
| max_steps: int = 10, |
There was a problem hiding this comment.
Defaults are important -- is max_steps 10 well motivated (and not e.g. 16, or 1024)?
|
Fixed in #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes so that the slice sampling is easier to run as a standalone kernel, in particular