fix(email): use efficient headers-only fetch for search mode #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously _search_emails() made N+1 subprocess calls: 1. notmuch search --output=messages (get IDs) 2. For each ID: notmuch show --format=raw (full email content) This was slow and could fail if raw email couldn't be fetched. Now uses single call: notmuch show --format=json --body=false which returns headers directly without body content. This is documented as "much faster and substantially smaller". 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Update MCP schema descriptions to emphasize that id: queries must use the ENTIRE message ID string including the @Domain part, not just the local part before the @. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
notmuch show --body=falsecallProblem
Previously
_search_emails()made N+1 subprocess calls:notmuch search --output=messagesto get message IDsnotmuch show --format=rawto fetch full raw emailThis was slow (multiple processes) and could fail if raw email parsing failed.
Solution
Use single
notmuch show --format=json --body=falsecall which returns headers directly. The--body=falseflag is documented as "much faster and substantially smaller".Test plan
🤖 Generated with Claude Code