feat: add body_file parameter to email compose and send tools #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements MCP-idiomatic email style system that influences LLM behavior before tool invocation: - Add email style configuration module with YAML config support - Implement MCP prompts for professional, casual, and academic styles - Enhance tool descriptions with dynamic style guidelines - Add style discovery tool for available prompts - Support XDG config directories and environment variables - Include comprehensive test suite with 19 test cases - Provide example configuration with 5 predefined styles Users can customize email styles by placing config at: - ~/.config/mcp-email/style.yml - ~/.emailstyle.yml - $EMAIL_STYLE_FILE environment variable 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Replace list indexing with next(iter(...), None) for more robust and idiomatic default style fallback when configured style is missing.
Keep version 0.13.1 from feature branch as it includes new functionality.
Enable compose to accept pre-drafted emails from draft_email() tool, allowing users to review and edit styled drafts in Mutt with signatures and encryption support before sending. - Add draft_file parameter to compose function - Extract recipient from draft for status message - Fix open() shadowing with builtins.open()
The email styling system was fundamentally flawed - LLMs compose message content before calling tools, so style guidelines couldn't influence the actual message composition. The system just added greetings/signoffs around already-written text. This commit: - Removes the entire draft_email tool and style configuration system - Adds body_file parameter to both send() and compose() tools - Makes body and body_file mutually exclusive as intended - Simplifies the codebase by removing unnecessary complexity The body_file parameter is genuinely useful for: - Loading pre-saved email drafts - Working with emails exported from other tools - Integrating with systems that produce .eml files
williamjameshandley
changed the title
Keep version 0.13.1 from feature branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
body_fileparameter to bothcompose()andsend()toolsWhy the styling system was removed
The email styling system was fundamentally flawed because:
What remains (the useful part)
The
body_fileparameter enables genuine workflows:.emlfilesImplementation
body_fileandbodyparameters are mutually exclusiveExample Usage
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]