Add basic filter for PHP 8 attribute at class level#24
Open
MarkCenturion wants to merge 2 commits intohanneskod:masterfrom
Open
Add basic filter for PHP 8 attribute at class level#24MarkCenturion wants to merge 2 commits intohanneskod:masterfrom
MarkCenturion wants to merge 2 commits intohanneskod:masterfrom
Conversation
Note this will clash with existing pull request on the original project, but as the pull request was not merged yet I needed to add this to continue my work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter classes based on presence of a PHP 8 attribute on a class level
Note this is a basic implementation that simply looks for at least one declaration of a given attribute class and considers this a match. Uses IS_INSTANCEOF by default thus automatically handling inheritance in attribute classes.
Attribute class name must be passed, not an instance of the attribute.
#[Attribute]
class CoolStuff { ... }
#[CoolStuff]
class BeCool { ... }
// Print all classes tagged with a CoolStuff attribute
foreach ($iter->attribute(CoolStuff::class) as $class) {
echo $class->getName();
}
Note this works only in PHP 8.0.1 or higher, but syntax is PHP 7 compatible so whilst this cannot be used on earlier versions it also won't break them. Tests should pass in PHP 8 or higher and be skipped otherwise.