homework №2 #102
Open
homework №2 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spajic
approved these changes
Nov 1, 2023
Collaborator
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
По коду всё чётко сделано, по замерам/профилированию см комменты
| @@ -0,0 +1,104 @@ | |||
| За основу взял оптимизированный по CPU код из первого задания | |||
|
|
||
| Первый отчет memory profiler | ||
| ``` | ||
| MEMORY USAGE: 122 MB |
Collaborator
There was a problem hiding this comment.
Не корректно смешивать замеры и профилирование
Само присутствие memory_profiler увеличивает потребление памяти
Правило: Замеры отдельно - профилирование отдельно
|  | ||
| Пик потребления не достигает даже 1мб, пробовал по разному запускать, результат не меняется, всегда пик 3.1kb, то же самое происходит и с heaptrack | ||
|  | ||
| Но простой прогон с puts в конце показывает |
| ``` | ||
| MEMORY USAGE: 30 MB | ||
| ``` | ||
| Программа теперь выполняется примерно за 9.6 секунд |
Collaborator
There was a problem hiding this comment.
👍 быстро и с минимальным потреблением памяти 👍
Comment on lines
+98
to
+99
| Пик потребления не достигает даже 1мб, пробовал по разному запускать, результат не меняется, всегда пик 3.1kb, то же самое происходит и с heaptrack | ||
|  |
Collaborator
There was a problem hiding this comment.
Возможно программа не запускается / либо что-то не работает
| File.foreach(ENV['DATA_FILE'] || filename || 'data.txt', chomp: true) do |line| | ||
| column_number = 0 | ||
|
|
||
| line.split(',') do |column_value| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.