Task-3 #96
Open
Task-3 #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spajic
approved these changes
Mar 30, 2023
Collaborator
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
Всё чётко, благодарю за работу
| После рефакторинга время рендера страницы изменилось с ~24000ms до ~6000ms | ||
|
|
||
| ### Правка №3 | ||
| Решил установить pg_hero и проанализировать запросы. pg_hero не предлавагал добавлять никакие индексы и все было в норме. Но я добавил индыксы на имя города, и составной индекс для трипов по from_id, to_id. Какой-то прибавки к скорости рендера это не дало, все осталось в пределах погрешности. |
Collaborator
There was a problem hiding this comment.
В данном случае да, так как почти всё время уходит на рендеринг паршлов
Но если смотреть с точки зрения оптимизации БД - очень полезно
В принципе можно оставлять паршлы, но юзать рендеринг коллекций, и там можно даже задать шаблон разделителя. Всё в одном файле быстрее работает, но всё-таки не так удобно для разработки (в реальном мире)
https://guides.rubyonrails.org/layouts_and_rendering.html#spacer-templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.