Add task 3 #97
Open
Add task 3 #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2023 11:11
spajic
reviewed
Apr 2, 2023
| </h1> | ||
| <h2> | ||
| <%= "В расписании #{@trips.count} рейсов" %> | ||
| <%= "В расписании #{@trips.load.size} рейсов" %> |
Collaborator
There was a problem hiding this comment.
👍 👍 , явно и сразу понятно что происходит, загрузили в массив, взяли размер
spajic
reviewed
Apr 2, 2023
| <% end %> | ||
| </ul> | ||
| <%= render "delimiter" %> | ||
| ==================================================== |
Collaborator
There was a problem hiding this comment.
Можно ещё с рендерингом коллекций и даже указать шаблон для разделителя https://guides.rubyonrails.org/layouts_and_rendering.html#spacer-templates
spajic
reviewed
Apr 2, 2023
| large.json - 8.34s | ||
| Разница драматическая, на этом эту часть заканчиваем | ||
|
|
||
| Поставил pg_hero - eму все нравится, полезной инфы - нет |
Collaborator
There was a problem hiding this comment.
Хмм, обычно он подсказывает индексы создать, если погонять запросы
spajic
approved these changes
Apr 2, 2023
| *Какими ещё результами можете поделиться* | ||
| - Bullet ожидаемо утомителен | ||
| - RMP ожидаемо хорош | ||
| - паршиалы - красиво и архитектурно, но ни дороговато ли они стоят подчас? Это главный вывод для меня сегодня. |
Collaborator
There was a problem hiding this comment.
Можно оставить себе удобство паршлов если рендерить коллекцией https://guides.rubyonrails.org/layouts_and_rendering.html#rendering-collections
там не такая критичная просадка по производительности по сравнению с циклом
| } | ||
| end | ||
|
|
||
| Trip.import!(trips) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.