[GDEF] Use a bit-set for representing mark-filtering-sets #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behdad
changed the title
|
I see 2% slowdown in NotoNastaliq; whereas in HB we don't see a slowdown. I still suggest we take it, since it improves NotoSansDuployan mega-font by over 10% in both HB & HR, even though we currently don't shape that font correctly. First need to sort out no_std though. |
This might be because the HB BitSet has more optimizations than Fontations U32Set. In particular, in HB we keep the last page accessed cached, to avoid a bsearch into the (granted, very small) page_map. |
My benchmarks are a bit off today. I'll do better benchmarking another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HB does this.
Not cleaned up. Waiting for googlefonts/fontations#1600
3% speedup in NotoNastaliqUrdu benchmark.