Skip to content

Conversation

@nyurik
Copy link
Contributor

@nyurik nyurik commented Aug 15, 2025

This is a subset of #90 - only adding cargo fmt as the automatic step. It should be merged before the #90.

Once enabled, pre-commit CI will keep all PRs clean by automatically doing cargo fmt and other minor linting, without requiring users to re-submit their changes. Note that this is done by CI on the server, and not by user's own git hook.

Maintainer TODO

sign-in into https://pre-commit.ci/ and enable this repo for automatic PR validation (we had tons of success with this at MapLibre, and many other projects)

Once enabled, pre-commit CI will keep all PRs clean by automatically doing `cargo fmt` and other minor linting, without requiring users to re-submit their changes. Note that this is done by CI on the server, and not by user's own git hook.

# Maintainer TODO

sign-in into https://pre-commit.ci/ and enable this repo for automatic PR validation (we had tons of success with this at MapLibre, and many other projects)
@nyurik nyurik changed the title chore: add pre-commit CI chore: add pre-commit CI: cargo fmt only Aug 15, 2025
@nyurik
Copy link
Contributor Author

nyurik commented Aug 22, 2025

cc: @dfrg and @behdad any blockers on this one?

@behdad
Copy link
Member

behdad commented Aug 22, 2025

I defer to @dfrg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants