Cache all fields from PairPos2 and avoid reading subtable #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@valadaptive this avoids subtable reparsing entirely for pairpos2. Would you mind checking if this improves your profile? |
|
Yes! This speeds up shaping Ubuntu Light by ~8% in the benchmark. |
|
Looks good in general. Should we remove the unused impl then? Any way to make this more harmonious across lookup types would be nice. Would it be too heavy to do this kind of caching on every lookups? |
|
Yes to all. This needs a bit of cleanup before merging, the code should be better structured to accommodate it and we should try to do this for all lookups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at #256