-
Notifications
You must be signed in to change notification settings - Fork 72
tool: expose the deprecated attribute
#49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tool: expose the deprecated attribute
#49
Conversation
WalkthroughReads Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller
participant Parser
participant ToolDef
Caller->>Parser: supply OpenAPI operation
Parser->>Parser: inspect operation metadata
Note right of Parser #DDEBF7: deprecated = operation.deprecated || false
Parser->>ToolDef: construct McpToolDefinition { ..., deprecated }
ToolDef-->>Caller: return tool definition (includes deprecated)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/parser/extract-tools.ts(2 hunks)
🔇 Additional comments (1)
src/parser/extract-tools.ts (1)
93-94: LGTM! Clean implementation of deprecated flag extraction.The logic correctly reads
operation.deprecatedand defaults tofalsewhen undefined or null. The placement is appropriate, computing the value just before tool object creation.
3985079 to
c8f4758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/parser/extract-tools.ts(2 hunks)src/types/index.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/parser/extract-tools.ts
Expose the `deprecated` attribute and default to `false`.
c8f4758 to
1d9a8d8
Compare
Waiting for the following PR to be merged: - harsha-iiiv/openapi-mcp-generator#54 - harsha-iiiv/openapi-mcp-generator#49
Expose the
deprecatedattribute and default tofalse.Summary by CodeRabbit