feat: add CI workflow for unit, integration and e2e tests #117

0xMMBD · 2025-12-10T12:08:05Z

Description:

Related issue(s):
#75

Fixes #

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Maciek Malik <[email protected]>

rbarker-dev · 2025-12-15T19:23:12Z

.github/workflows/pr-tests.yml

+
+on:
+  pull_request:
+    branches: [ main, "feat/75-tests-ci" ]


Suggested change

branches: [ main, "feat/75-tests-ci" ]

branches:

- main

- feat/75-tests-ci

Prefer to list out the matrix values.

And will probably need to remove the feat/75-tests-ci branch before merging.

yes that branch shouldn't be here, it was here just for testing

rbarker-dev · 2025-12-15T19:23:23Z

.github/workflows/pr-tests.yml

+    uses: ./.github/workflows/run-unit-tests.yml
+
+  integration-tests:
+    needs: [ unit-tests ]


Prefer to list out the matrix values.

rbarker-dev · 2025-12-15T19:23:31Z

.github/workflows/pr-tests.yml

+      PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}
+
+  e2e-tests:
+    needs: [ integration-tests ]


Prefer to list out the matrix values.

rbarker-dev · 2025-12-15T19:25:53Z

.github/workflows/run-e2e-tests.yml

+      OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
+      ACCOUNT_ID: ${{ secrets.ACCOUNT_ID }}
+      PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}
+      E2E_LLM_PROVIDER: ${{ vars.E2E_LLM_PROVIDER }}


Suggested change

E2E_LLM_PROVIDER: ${{ vars.E2E_LLM_PROVIDER }}

E2E_LLM_PROVIDER: ${{ inputs.e2e-llm-provider }}

this needs to be passed in as an input

sure, I'll adjust that.
It was done in the same way as we have currently in the agent kit JS repo. Do you think it's worth changing it over there too to keep it consistent? @rbarker-dev

rbarker-dev · 2025-12-15T19:26:56Z

.github/workflows/run-e2e-tests.yml

+        description: Working directory
+        required: false
+        default: 'python'
+        type: string


Suggested change

type: string

type: string

e2e-llm-provider:

description: LLM provider for e2e tests

required: true/false

default: <SOME_VALUE> # please fill this in

type: string

rbarker-dev · 2025-12-15T19:27:30Z

.github/workflows/pr-tests.yml

+
+  e2e-tests:
+    needs: [ integration-tests ]
+    uses: ./.github/workflows/run-e2e-tests.yml


Suggested change

uses: ./.github/workflows/run-e2e-tests.yml

uses: ./.github/workflows/run-e2e-tests.yml

with:

e2e-llm-provider: <SOME_VALUE>

rbarker-dev · 2025-12-15T19:31:46Z

.github/workflows/run-integration-tests.yml

+      workdir:
+        description: Working directory
+        required: false
+        default: 'python'
+        type: string


Suggested change

workdir:

description: Working directory

required: false

default: 'python'

type: string

workdir:

description: Working directory

required: false

default: 'python'

type: string

e2e-llm-provider:

description: LLM Provider for E2E Integration Tests

required: true/false

default: <SOME_VALUE>

type: string

rbarker-dev · 2025-12-15T19:32:08Z

.github/workflows/run-integration-tests.yml

+      OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
+      ACCOUNT_ID: ${{ secrets.ACCOUNT_ID }}
+      PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}
+      E2E_LLM_PROVIDER: ${{ vars.E2E_LLM_PROVIDER }}


Suggested change

E2E_LLM_PROVIDER: ${{ vars.E2E_LLM_PROVIDER }}

E2E_LLM_PROVIDER: ${{ inputs.e2e-llm-provider }}

rbarker-dev · 2025-12-15T19:32:58Z

.github/workflows/run-integration-tests.yml

+      - name: Run integration tests (throttled)
+        working-directory: ${{ inputs.workdir }}
+        env:
+          TEST_DELAY_MS: '8000'


Suggested change

TEST_DELAY_MS: '8000'

TEST_DELAY_MS: '8000' # <Add a comment for why 8000ms sleep is required>

rbarker-dev · 2025-12-15T19:34:01Z

.github/workflows/pr-tests.yml

+
+  integration-tests:
+    needs: [ unit-tests ]
+    uses: ./.github/workflows/run-integration-tests.yml


Suggested change

uses: ./.github/workflows/run-integration-tests.yml

uses: ./.github/workflows/run-integration-tests.yml

with:

e2e-llm-provider: <SOME_VALUE>

andrewb1269 · 2025-12-15T19:45:04Z

.github/workflows/pr-tests.yml

+    needs: [ unit-tests ]
+    uses: ./.github/workflows/run-integration-tests.yml
+    secrets:
+      OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}


Suggested change

OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}

LLM_API_KEY: ${{ secrets.OPENAI_API_KEY }}

andrewb1269 · 2025-12-15T19:45:16Z

.github/workflows/pr-tests.yml

+    needs: [ integration-tests ]
+    uses: ./.github/workflows/run-e2e-tests.yml
+    secrets:
+      OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}


Suggested change

OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}

LLM_API_KEY: ${{ secrets.OPENAI_API_KEY }}

andrewb1269 · 2025-12-15T19:45:28Z

.github/workflows/run-e2e-tests.yml

+        default: 'python'
+        type: string
+    secrets:
+      OPENAI_API_KEY:


Suggested change

OPENAI_API_KEY:

LLM_API_KEY:

andrewb1269 · 2025-12-15T19:46:03Z

.github/workflows/pr-tests.yml

+
+on:
+  pull_request:
+    branches: [ main, "feat/75-tests-ci" ]


And will probably need to remove the feat/75-tests-ci branch before merging.

andrewb1269 · 2025-12-15T19:46:34Z

.github/workflows/run-e2e-tests.yml

+    runs-on: hedera-agent-linux-medium
+    env:
+      WORKDIR: python
+      OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}


Suggested change

OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}

LLM_API_KEY: ${{ secrets.OPENAI_API_KEY }}

andrewb1269 · 2025-12-15T19:47:04Z

.github/workflows/run-integration-tests.yml

+        default: 'python'
+        type: string
+    secrets:
+      OPENAI_API_KEY:


Suggested change

OPENAI_API_KEY:

LLM_API_KEY:

andrewb1269 · 2025-12-15T19:47:31Z

.github/workflows/run-integration-tests.yml

+    runs-on: hedera-agent-linux-medium
+    env:
+      WORKDIR: python
+      OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}


Suggested change

OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}

LLM_API_KEY: ${{ secrets.OPENAI_API_KEY }}

0xMMBD force-pushed the feat/75-tests-ci branch 6 times, most recently from cc9883c to 8810c05 Compare December 11, 2025 13:23

0xMMBD changed the title ~~wip CI tests~~ feat: add CI workflow for unit, integration and e2e tests Dec 11, 2025

feat: add CI workflow for unit, integration and e2e tests

9ddbf9d

Signed-off-by: Maciek Malik <[email protected]>

0xMMBD force-pushed the feat/75-tests-ci branch from 8810c05 to 9ddbf9d Compare December 11, 2025 13:24

Merge branch 'main' into feat/75-tests-ci

97a66ae

0xMMBD marked this pull request as ready for review December 11, 2025 13:24

0xMMBD requested review from a team as code owners December 11, 2025 13:24

0xMMBD requested a review from rbarker-dev December 11, 2025 13:24

0xMMBD added 2 commits December 12, 2025 15:09

Merge branch 'main' into feat/75-tests-ci

9ceebaa

Merge branch 'main' into feat/75-tests-ci

45f2d11

rbarker-dev requested changes Dec 15, 2025

View reviewed changes

andrewb1269 requested changes Dec 15, 2025

View reviewed changes

	E2E_LLM_PROVIDER: ${{ vars.E2E_LLM_PROVIDER }}
	E2E_LLM_PROVIDER: ${{ inputs.e2e-llm-provider }}

-        type: string
+        type: string
+      e2e-llm-provider:
+        description: LLM provider for e2e tests
+        required: true/false
+        default: <SOME_VALUE> # please fill this in
+        type: string

	TEST_DELAY_MS: '8000'
	TEST_DELAY_MS: '8000' # <Add a comment for why 8000ms sleep is required>

	OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
	LLM_API_KEY: ${{ secrets.OPENAI_API_KEY }}

feat: add CI workflow for unit, integration and e2e tests #117

Are you sure you want to change the base?

feat: add CI workflow for unit, integration and e2e tests #117

Uh oh!

Conversation

0xMMBD commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

0xMMBD commented Dec 10, 2025 •

edited

Loading