-
Notifications
You must be signed in to change notification settings - Fork 29
Add sorting foundation as util and using it within indexed-db-handler #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕺 This looks great, a few minor comments, I think continuing this pattern for the other types with tests is all that's really left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! Just left a couple of suggestions
Use the schema for a stricter lookup of existing attribute. The two value exceptions currently supported are created_time and id. created_time exists on every record from the api but may not be defined on the model. id exists on every record but is not considered an attribute by json api record definition
When sorting on an attribute it should be an attribute explicitly defined on the mode, or an id or created_time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! Awesome work!
Just left one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I picked up the PR for some tweaks I am going to approve it as is. The need for a custom sorting or multi-sort might be necessary in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
This pull request adds the ability to specify sorting options when querying the store:
🎟️ Jira ticket
How to Test
addons/api