-
Notifications
You must be signed in to change notification settings - Fork 29
Icu 16546 upgrade ember for admin UI #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕺 One question but no blockers at all. Nice work, thanks for the upgrade. I can't wait to use the new toys. I noticed @ember/test-helpers
was downgraded but I have #2797 that I want to rebase after all the ember upgrade work that'll get all @ember/test-helpers
in the monorepo to v5
Thats awesome!! Yeah only reason I had to downgrade (& match new blueprints) is because v4 was causing an error in the test env. Funny enough, once upgrading the api addon to v5.12, I can update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! looks good to me
Description
Screenshots (if appropriate)
How to Test
Desktop Releases Test Run
Checklist