Skip to content

Icu 16546 upgrade ember for admin UI #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2025

Conversation

lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Apr 23, 2025

Description

  1. Update admin ui to ember v5.12
  2. Run ember init & codemods
  3. Run linter + formatter

Screenshots (if appropriate)

image

How to Test

Desktop Releases Test Run

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 9:16pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 9:16pm

Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺 One question but no blockers at all. Nice work, thanks for the upgrade. I can't wait to use the new toys. I noticed @ember/test-helpers was downgraded but I have #2797 that I want to rebase after all the ember upgrade work that'll get all @ember/test-helpers in the monorepo to v5

@lisbet-alvarez
Copy link
Collaborator Author

I noticed @ember/test-helpers was downgraded but I have #2797 that I want to rebase after all the ember upgrade work that'll get all @ember/test-helpers in the monorepo to v5

Thats awesome!! Yeah only reason I had to downgrade (& match new blueprints) is because v4 was causing an error in the test env. Funny enough, once upgrading the api addon to v5.12, I can update @ember/test-helpers to v4 with no errors.
image

Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! looks good to me

@lisbet-alvarez lisbet-alvarez merged commit 620f822 into main Apr 25, 2025
13 checks passed
@lisbet-alvarez lisbet-alvarez deleted the ICU-16546-upgrade-ember-admin-ui branch April 25, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants