Skip to content

Conversation

@wongtonyb
Copy link
Collaborator

@wongtonyb wongtonyb commented Jul 15, 2025

βœ… Closes: https://hashicorp.atlassian.net/browse/ICU-17174

Description

Update playwright locators for e2e tests.
Updated navigation steps to session-recording tests

Screenshots (if appropriate)

How to Test

  • passing for @ce @docker tests (pnpm admin:ce:docker)
  • passing for @ent @docker tests (pnpm admin:ent:docker)

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@wongtonyb wongtonyb requested a review from a team as a code owner July 15, 2025 20:45
@vercel
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
boundary-ui βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 17, 2025 7:37pm
boundary-ui-desktop βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 17, 2025 7:37pm

dillanb-hashi
dillanb-hashi previously approved these changes Jul 15, 2025
Copy link
Collaborator

@dillanb-hashi dillanb-hashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and much cleaner, thanks for the refactor!

@wongtonyb wongtonyb changed the title refactor: πŸ’‘ e2e tests - update locators refactor: πŸ’‘ e2e admin tests - update locators Jul 17, 2025
@wongtonyb wongtonyb merged commit b99fce7 into main Jul 17, 2025
13 checks passed
@wongtonyb wongtonyb deleted the ICU-17174-locator-updates branch July 17, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants