Skip to content

Conversation

@priya-patel04
Copy link
Collaborator

@priya-patel04 priya-patel04 commented Oct 24, 2025

Description

Adds a new Preferred Clients section on Settings Page.

🎟️ Jira ticket

Screenshots (if appropriate)

Mac:

Screen.Recording.2025-10-27.at.12.35.57.PM.mov
Screenshot 2025-10-27 at 1 21 26β€―PM

None detected:

Screen.Recording.2025-10-28.at.5.24.31.PM.mov

Windows:

Screen.Recording.2025-10-27.at.1.06.55.PM.mov
Screenshot 2025-10-27 at 1 25 33β€―PM

None detected:

Screen.Recording.2025-10-28.at.6.05.18.PM.mov

How to Test

  1. Navigate to Settings page and verify a new Preferred Clients section is rendered
    • Mac: Windows App should be selected by default as your preferred client
    • Windows: Mstc should be selected by default as your preferred client
  2. Test updating your preferred client to None. Reopen the app and verify None selection persists.
  3. Verfiy electron stores/update preferred client selection in the config:
    • Mac: /Library/Application Support/Boundary/config.json
    • Windows: \AppData\Roaming\Boundary\config.json

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Oct 31, 2025 9:28pm
boundary-ui-desktop Ready Ready Preview Comment Oct 31, 2025 9:28pm

Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Would this work already with a test desktop client build? I can give that a try tomorrow if so.

My feedback is:

  • another test (or test assertion in the existing test) to check that the data is responding from the change event
  • try and assign these known set of values to constants that are exported from the best source module (maybe ui/desktop/app/services/rdp.js)

@priya-patel04
Copy link
Collaborator Author

This looks great! Would this work already with a test desktop client build? I can give that a try tomorrow if so.

My feedback is:

  • another test (or test assertion in the existing test) to check that the data is responding from the change event
  • try and assign these known set of values to constants that are exported from the best source module (maybe ui/desktop/app/services/rdp.js)

Yes, we can test with local DC build.

Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic around getting the clients could be less coupled in how it's set up. Also if the methods have several conditions in a service and they're not exercised by the rendering or acceptance tests it would be good to have unit tests around them.

I think there are some cases here that might need a few acceptance since they rely on certain state being set in the beforeModel hook and it would be good to ensure that the data coming from ipc is set up on the rdp service and then seen on the settings. That could be done up in a follow-up PR though.

hashicc
hashicc previously approved these changes Oct 31, 2025
Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€ Looks good! Thanks for all the work on this

DhariniJeeva
DhariniJeeva previously approved these changes Oct 31, 2025
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! πŸŽ‰

@priya-patel04 priya-patel04 merged commit ef62b19 into llb/rdp-client-launch Oct 31, 2025
12 of 13 checks passed
@priya-patel04 priya-patel04 deleted the preferred_clients_section_on_settings_page branch October 31, 2025 21:52
priya-patel04 added a commit that referenced this pull request Nov 3, 2025
* feat: 🎸 preferred clients section on settings page

* chore: πŸ€– update mock ipc with new handlers

* refactor: πŸ’‘ moved windows rdp protocol to const

* refactor: πŸ’‘ moved rdp calls to app route

* test: πŸ’ fixed failings tests

* refactor: πŸ’‘ addressed comments

* fix: πŸ› fixed failing tests

* refactor: πŸ’‘ add mock rdp service calls to tests

* refactor: πŸ’‘ addressed comments

* test: πŸ’ add additional tests

* refactor: πŸ’‘ fixed test failure
DhariniJeeva pushed a commit that referenced this pull request Nov 4, 2025
* feat: 🎸 preferred clients section on settings page

* chore: πŸ€– update mock ipc with new handlers

* refactor: πŸ’‘ moved windows rdp protocol to const

* refactor: πŸ’‘ moved rdp calls to app route

* test: πŸ’ fixed failings tests

* refactor: πŸ’‘ addressed comments

* fix: πŸ› fixed failing tests

* refactor: πŸ’‘ add mock rdp service calls to tests

* refactor: πŸ’‘ addressed comments

* test: πŸ’ add additional tests

* refactor: πŸ’‘ fixed test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants