-
Notifications
You must be signed in to change notification settings - Fork 32
Icu 17881 UI desktop add rdp launch button in target detail view #3038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icu 17881 UI desktop add rdp launch button in target detail view #3038
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
df812fb to
51b0c69
Compare
a67d884 to
a000a6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm not entirely sure if the try/catch is necessary when quickConnectAndLaunchRdp already has one?
ui/desktop/app/controllers/scopes/scope/projects/targets/target.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good!
Description
This pr adds support to launch rdp client from target details page
https://hashicorp.atlassian.net/browse/ICU-17879
https://hashicorp.atlassian.net/browse/ICU-17881
Screenshots (if appropriate)
rdp target with
windows-appclient:tcp target:

How to Test
note: reach out for cluster details if you'd like to test this]
@tracked preferredRdpClient = 'windows-app'for mac and@tracked preferredRdpClient = 'mstsc'for windowsopento launch rdp clientChecklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.