Skip to content

Conversation

@DhariniJeeva
Copy link
Collaborator

@DhariniJeeva DhariniJeeva commented Oct 29, 2025

Description

This pr adds support to launch rdp client from target details page
https://hashicorp.atlassian.net/browse/ICU-17879
https://hashicorp.atlassian.net/browse/ICU-17881

Screenshots (if appropriate)

rdp target with windows-app client:

Screenshot 2025-10-29 at 11 50 49 AM

tcp target:
Screenshot 2025-10-28 at 6 04 13 PM

How to Test

note: reach out for cluster details if you'd like to test this]

  • since we don't have a way to set preffered client in the settings view yet, we can just update the service to hardcode the client such as @tracked preferredRdpClient = 'windows-app' for mac and @tracked preferredRdpClient = 'mstsc' for windows
  • click on rdp target to get to the details page
  • click on open to launch rdp client
  • should see connect for non rdp targets or rdp target with no preferred client(if step 1 is not done)

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@DhariniJeeva DhariniJeeva requested a review from a team as a code owner October 29, 2025 01:14
@DhariniJeeva DhariniJeeva self-assigned this Oct 29, 2025
@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Oct 30, 2025 10:28pm
boundary-ui-desktop Ready Ready Preview Comment Oct 30, 2025 10:28pm

Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm not entirely sure if the try/catch is necessary when quickConnectAndLaunchRdp already has one?

Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good!

@DhariniJeeva DhariniJeeva merged commit 7e284c8 into llb/rdp-client-launch Oct 31, 2025
12 checks passed
@DhariniJeeva DhariniJeeva deleted the ICU-17881-ui-desktop-add-rdp-launch-button-in-target-detail-view branch October 31, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants