enable updates to probes in gateways #4901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanikachavan5
added
pr/no-changelog
sanikachavan5
force-pushed
the
sanikachavan5/include-inital-delay-seconds-as-field--for-gateway-controller-update
branch
2 times, most recently
from
b15b906 to
a4bec48
Compare
sanikachavan5
changed the title
LakshmiNarayananDesikan
previously approved these changes
Oct 29, 2025
sanikachavan5
force-pushed
the
sanikachavan5/include-inital-delay-seconds-as-field--for-gateway-controller-update
branch
from
314774b to
b402cf9
Compare
srahul3
previously approved these changes
Nov 18, 2025
Contributor
srahul3
left a comment
srahul3
left a comment
There was a problem hiding this comment.
✅ LGTM. Thanks for the great job 🚀
- Introduced configuration for liveness, readiness, and startup probes in GatewayClassConfig. - Updated related templates and values to handle probe configurations. - Enhanced command to load probes from a config map.
Introduced a new mechanism to extract probe configurations directly from Gateway annotations.
sanikachavan5
force-pushed
the
sanikachavan5/include-inital-delay-seconds-as-field--for-gateway-controller-update
branch
from
90248ec to
f45f18e
Compare
sanikachavan5
added
backport/1.8.x
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces per-Gateway health probe configuration for API Gateway pods in Consul on Kubernetes, allowing users to set custom liveness, readiness, and startup probes via annotations on Gateway resources. The implementation includes parsing and validation logic for these probe annotations, integration into the deployment reconciliation flow, and documentation for users. Minor related improvements and tests are also included.
API Gateway Probe Configuration
consul.hashicorp.com/liveness-probe,consul.hashicorp.com/readiness-probe, andconsul.hashicorp.com/startup-probeannotations, with JSON-formatted probe configuration. This allows fine-grained health checking tailored to each Gateway. [1] [2]ProbesFromGatewayincontrol-plane/api-gateway/gatekeeper/probes.goto parse and validate probe annotations, ensuring only one probe handler is set and normalizingsuccessThresholdfor liveness/startup probes.Deployment Reconciliation and Propagation
control-plane/api-gateway/gatekeeper/deployment.goto apply parsed probe configurations from Gateway annotations to the primary container in Gateway deployments. This ensures probe changes trigger rollout and are reflected in the running pods. [1] [2]Testing and Documentation
charts/consul/README.mdwith documentation and examples for configuring Gateway probes using annotations.### Changes proposed in this PR ###How I've tested this PR
How I expect reviewers to test this PR
Checklist
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.