Update x/sys to support go 1.17 #10869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dnephin
added
the
pr/no-changelog
dnephin
approved these changes
Aug 18, 2021
Contributor
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
Thank you for the PR! This LGTM.
Adding these two links which I found from the homebrew link you provided:
dnephin
added
the
pr/dependencies
Collaborator
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/429699. |
Contributor
Author
|
@dnephin can we make a new release of consul |
This was referenced Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support go 1.17 so that homebrew can build this package we need to update x/sys and cut a new release
More context here: Homebrew/homebrew-core#83413