Skip to content

draft: poc for delta check for notifications #23125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrgupta7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

draft: poc for delta check for notifications #23125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions agent/consul/config_endpoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,10 +481,23 @@ func (c *ConfigEntry) ResolveServiceConfig(args *structs.ServiceConfigRequest, r
return err
}

// Compute the resolved service config.
// This merges together all relevant config entries.
// After this we compare the config with the old hash
// to see if anything changed.
thisReply, err := configentry.ComputeResolvedServiceConfig(
args,
entries,
c.logger,
)
if err != nil {
return err
}

// Generate a hash of the config entry content driving this
// response. Use it to determine if the response is identical to a
// prior wakeup.
newHash, err := hashstructure_v2.Hash(entries, hashstructure_v2.FormatV2, nil)
newHash, err := hashstructure_v2.Hash(thisReply, hashstructure_v2.FormatV2, nil)
if err != nil {
return fmt.Errorf("error hashing reply for spurious wakeup suppression: %w", err)
}
Expand All @@ -500,14 +513,6 @@ func (c *ConfigEntry) ResolveServiceConfig(args *structs.ServiceConfigRequest, r
ranOnce = true
}

thisReply, err := configentry.ComputeResolvedServiceConfig(
args,
entries,
c.logger,
)
if err != nil {
return err
}
thisReply.Index = index

*reply = *thisReply
Expand Down
Loading