-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inert synchronization issue #2431
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
c3732eb
to
a0228a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for contributing this fix! π
It now works as expected; I left a few nit comments, but otherwise looking great and good to be merged
showcase/tests/integration/components/hds/side-nav/index-test.js
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/side-nav/index-test.js
Outdated
Show resolved
Hide resolved
Fixed tense and added a missing word. Co-authored-by: Alex <[email protected]>
2a3aae1
to
04e9975
Compare
Thanks for the review @alex-ju! I believe I addressed everything. Sorry about the lingering console.logs and very good to know about property/method/action ordering. |
to be fair, we're due to update our contribution guidelines, so I'll make sure to include such things |
π thank you @DingoEatingFuzz! |
π Summary
If merged this PR will fix two bugs related to the inert state of
Hds::SideNav
when the viewport changes sizes.π οΈ Detailed description
Right now we toggle the
inert
state of certain elements when the menu is manually minimized or expanded. However, there are two other ways the menu can be minimized/expanded:This is simple enough to test today in production:
πΈ Screenshots
π External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.