Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Link "Do" link update #2435

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Inline Link "Do" link update #2435

merged 1 commit into from
Sep 20, 2024

Conversation

andgen404
Copy link
Contributor

@andgen404 andgen404 commented Sep 20, 2024

📌 Summary

If merged, this PR will update the "Do" link text.

🛠️ Detailed description

For better accessibility, use "HashiCorp Developer tutorial library" as the example link text to provide a full, unique accessible name. The current short example may cause confusion and could violate code linting rules like no-invalid-link-text that discourage non-unique or overly brief link text.

📸 Screenshots

Before
Before Image

After
Screenshot 2024-09-19 at 5 08 17 PM

🔗 External links

Jira ticket: HDS-3582


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Sep 20, 2024 0:09am
hds-website ✅ Ready (Inspect) Visit Preview Sep 20, 2024 0:09am

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Sep 20, 2024
@andgen404 andgen404 requested review from a team September 20, 2024 00:09
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I'm good with it, nice catch on this Andrew!

@andgen404 andgen404 merged commit 26a4cdc into main Sep 20, 2024
10 checks passed
@andgen404 andgen404 deleted the Inline-link-guidence branch September 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants