Convert Shw::Outliner component to GTS
#2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@zamoore you also have to update the template registry and add an |
|
@didoo - thanks, let me know if that change looks right |
aklkv
reviewed
Sep 20, 2024
| import Component from '@glimmer/component'; | ||
|
|
||
| export interface ShwOutlinerSignature { | ||
| Blocks: { |
There was a problem hiding this comment.
just FYI: not having even empty Args block here might break types in the context of an other .gts component, but it's fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR converts the
Shw::Outlinercomponent to GTS.🔗 External links
Jira ticket: HDS-3836
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.