Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shw::Flex GTS Conversion #2440

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Shw::Flex GTS Conversion #2440

merged 4 commits into from
Sep 23, 2024

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Sep 20, 2024 •
edited by didoo
Loading

📌 Summary

If merged, this PR updates the Shw::Flex component to the new GTS format.

🔗 External links

Jira ticket: HDS-3381

👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Sep 23, 2024 3:50pm
hds-website ✅ Ready (Inspect) Visit Preview Sep 23, 2024 3:50pm

@zamoore zamoore self-assigned this Sep 20, 2024
@zamoore zamoore requested review from aklkv and a team September 20, 2024 16:13
@zamoore zamoore marked this pull request as ready for review September 20, 2024 16:13
didoo
didoo reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

showcase/app/components/shw/flex/index.gts Outdated Show resolved Hide resolved
showcase/app/components/shw/flex/item.gts Outdated Show resolved Hide resolved
showcase/app/components/shw/flex/item.gts Show resolved Hide resolved
@zamoore zamoore requested a review from didoo September 20, 2024 17:59
aklkv
aklkv approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@aklkv aklkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from ShwFlexLabel -> ShwLabel Looks good 👍🏻

@zamoore zamoore merged commit a2079a8 into main Sep 23, 2024
14 checks passed
@zamoore zamoore deleted the 3831-Shw/Flex-GTS branch September 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didoo didoo didoo left review comments

@aklkv aklkv aklkv approved these changes

Assignees

@zamoore zamoore

Labels
showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zamoore @aklkv @didoo @hashibot-hds