-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log impilict constraints to log if level=trace #25233
base: main
Are you sure you want to change the base?
Log impilict constraints to log if level=trace #25233
Conversation
…raints considered in an evaluation.
…raints considered in an evaluation.
…execution commands. provision order: - './scripts/linux-priv-go.sh' requires `curl`, that is installed by './scripts/linux-priv-config.sh'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @softwaremastermind! The job inspect
command already includes all this information because its persisted to Raft. I'm having trouble imagining a debugging scenario where it'd be more useful to have this in logs (typically available only to the cluster admin) vs the job inspect
(available to any job author).
Do you typically run with trace logging enabled? I worry this could get really expensive for busy clusters when running tools like nomad operator debug
.
Hi @tgross, thank you very much for the fast and appreciative reply. We do not run with log level |
@softwaremastermind the other tool that might help you if you want more continuous monitoring is the event stream API. That reflects the writes that Nomad makes to its internal state store, so that'd include any implicitly created constraints as well. You can subscribe to subsets of the stream by topic or namespace. |
Description
This merge request resulted from a troubleshooting process in an internal Nomad cluster. Before Nomad performs an evaluation, it adds a set of implicit constraints to a job (Job#admissionMutators).
The information about all implicit constraints considered in the log files would have supported troubleshooting. This merge request offers code that logs the implicit constraints when the log level is
trace
.Testing & Reproduction steps
I have made some minor changes to the Vagrant setup to run Vagrant on Ubuntu 24.04.2 LTS.
Links
Scheduling in Nomad
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.