r/cognito_resource_server allow name change without ForceNew

[mbbush]

Description

Allow updates to the name (which is really just a description) of the cognito resource server without deleting and recreating it.

Relations

Closes #41347

References

Output from Acceptance Testing

% make testacc TESTS=TestAccCognitoIDPResourceServer PKG=cognitoidp
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPResourceServer'  -timeout 360m -vet=off
2025/03/06 09:32:09 Initializing Terraform AWS Provider...
=== RUN   TestAccCognitoIDPResourceServer_basic
=== PAUSE TestAccCognitoIDPResourceServer_basic
=== RUN   TestAccCognitoIDPResourceServer_disappears
=== PAUSE TestAccCognitoIDPResourceServer_disappears
=== RUN   TestAccCognitoIDPResourceServer_scope
=== PAUSE TestAccCognitoIDPResourceServer_scope
=== RUN   TestAccCognitoIDPResourceServer_nameChange
=== PAUSE TestAccCognitoIDPResourceServer_nameChange
=== CONT  TestAccCognitoIDPResourceServer_basic
=== CONT  TestAccCognitoIDPResourceServer_scope
=== CONT  TestAccCognitoIDPResourceServer_nameChange
=== CONT  TestAccCognitoIDPResourceServer_disappears
--- PASS: TestAccCognitoIDPResourceServer_disappears (15.33s)
--- PASS: TestAccCognitoIDPResourceServer_basic (17.68s)
--- PASS: TestAccCognitoIDPResourceServer_nameChange (22.90s)
--- PASS: TestAccCognitoIDPResourceServer_scope (33.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	33.666s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[mbbush]

I was not able to find a good example to follow for asserting that the resource is not deleted and recreated by terraform.

The examples I did find all used some unique attribute in the AWS api response, like a creation date, to make the assertion, but there is no such attribute available for this resource. The only option I can think of would be to add an assertion on the Plan, but I don't know how to do that, and I'm not sure if it's necessary.