Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added security configuration resource to EMR containers #41716

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

trina242
Copy link

@trina242 trina242 commented Mar 7, 2025

Description

This PR adds a new resource aws_emrcontainers_security_configuration is similar in its purpose to existing aws_emr_security_configuration, but for EMR containers. The reference can be added to aws_emrcontainers_virtual_cluster - it allows to enable recently added fine-grained access control powered by AWS Lake Formation, as well as encryption in transit, for EMR on EKS.

Additionally, failing acceptance tests for aws_emrcontainers_virtual_cluster are now fixed and skipped in short-run (until now the provider tried to create virtual cluster before EKS cluster was provisioned or when its network configuration was being updated).

Relations

Closes #41712

References

https://docs.aws.amazon.com/emr-on-eks/latest/APIReference/API_CreateSecurityConfiguration.html
https://docs.aws.amazon.com/emr-on-eks/latest/APIReference/API_DescribeSecurityConfiguration.html
https://aws.amazon.com/about-aws/whats-new/2025/02/fine-grained-control-aws-lake-formation-emr-eks/

Output from Acceptance Testing

%  make testacc PKG=emrcontainers                                          ✔  3s   05:52:52 AM  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/emrcontainers/... -v -count 1 -parallel 20   -timeout 360m -vet=off
2025/03/07 05:53:24 Initializing Terraform AWS Provider...
=== RUN   TestAccEMRContainersJobTemplate_basic
=== PAUSE TestAccEMRContainersJobTemplate_basic
=== RUN   TestAccEMRContainersJobTemplate_disappears
=== PAUSE TestAccEMRContainersJobTemplate_disappears
=== RUN   TestAccEMRContainersJobTemplate_tags
=== PAUSE TestAccEMRContainersJobTemplate_tags
=== RUN   TestAccEMRContainersSecurityConfiguration_basic
=== PAUSE TestAccEMRContainersSecurityConfiguration_basic
=== RUN   TestEndpointConfiguration
=== RUN   TestEndpointConfiguration/service_aws_envvar
=== RUN   TestEndpointConfiguration/use_fips_config
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar
=== RUN   TestEndpointConfiguration/base_endpoint_envvar
=== RUN   TestEndpointConfiguration/base_endpoint_config_file
=== RUN   TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config
=== RUN   TestEndpointConfiguration/no_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_config_file
=== RUN   TestEndpointConfiguration/service_config_file_overrides_base_config_file
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file
--- PASS: TestEndpointConfiguration (0.38s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar (0.02s)
    --- PASS: TestEndpointConfiguration/use_fips_config (0.01s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.01s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.02s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.01s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.02s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.01s)
    --- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.01s)
    --- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.02s)
    --- PASS: TestEndpointConfiguration/no_config (0.01s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.02s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.01s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.01s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.01s)
    --- PASS: TestEndpointConfiguration/service_config_file (0.01s)
    --- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.01s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.02s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.02s)
=== RUN   TestAccEMRContainersVirtualClusterDataSource_basic
=== PAUSE TestAccEMRContainersVirtualClusterDataSource_basic
=== RUN   TestAccEMRContainersVirtualCluster_basic
=== PAUSE TestAccEMRContainersVirtualCluster_basic
=== RUN   TestAccEMRContainersVirtualCluster_disappears
=== PAUSE TestAccEMRContainersVirtualCluster_disappears
=== RUN   TestAccEMRContainersVirtualCluster_tags
=== PAUSE TestAccEMRContainersVirtualCluster_tags
=== CONT  TestAccEMRContainersJobTemplate_basic
=== CONT  TestAccEMRContainersVirtualClusterDataSource_basic
=== CONT  TestAccEMRContainersVirtualCluster_disappears
=== CONT  TestAccEMRContainersVirtualCluster_tags
=== CONT  TestAccEMRContainersJobTemplate_tags
=== CONT  TestAccEMRContainersSecurityConfiguration_basic
=== CONT  TestAccEMRContainersJobTemplate_disappears
=== CONT  TestAccEMRContainersVirtualCluster_basic
--- PASS: TestAccEMRContainersJobTemplate_disappears (21.51s)
--- PASS: TestAccEMRContainersJobTemplate_tags (24.39s)
--- PASS: TestAccEMRContainersJobTemplate_basic (25.11s)
--- PASS: TestAccEMRContainersSecurityConfiguration_basic (26.08s)
--- PASS: TestAccEMRContainersVirtualCluster_disappears (1148.51s)
--- PASS: TestAccEMRContainersVirtualCluster_basic (1243.10s)
--- PASS: TestAccEMRContainersVirtualClusterDataSource_basic (1338.20s)
--- PASS: TestAccEMRContainersVirtualCluster_tags (1393.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers      1398.523s


...

@trina242 trina242 requested a review from a team as a code owner March 7, 2025 07:02
Copy link

github-actions bot commented Mar 7, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Mar 7, 2025
@trina242 trina242 force-pushed the f-emrcontainers-security-configuration branch from cc8e9d5 to 4dd0b97 Compare March 7, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Security configuration for EMR containers (Lake Formation support)
1 participant