Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(RDS): Setting performance_insights_* to requiresModifyDbCluster #41737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rshade
Copy link

@rshade rshade commented Mar 7, 2025

Description

Bug(RDS): Setting performance_insights_* to requiresModifyDbCluster = true for global_clusters

Relations

Closes #41378

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSCluster_GlobalClusterPerformanceInsightsEnabled PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_GlobalClusterPerformanceInsightsEnabled'  -timeout 360m -vet=off
2025/03/10 13:33:06 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCluster_GlobalClusterPerformanceInsightsEnabled
=== PAUSE TestAccRDSCluster_GlobalClusterPerformanceInsightsEnabled
=== CONT  TestAccRDSCluster_GlobalClusterPerformanceInsightsEnabled
--- PASS: TestAccRDSCluster_GlobalClusterPerformanceInsightsEnabled (232.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        232.809s
...

Copy link

github-actions bot commented Mar 7, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. labels Mar 7, 2025
@rshade rshade force-pushed the global_rds_perf_insights branch 2 times, most recently from 9687db7 to ce085eb Compare March 10, 2025 18:37
@rshade rshade marked this pull request as ready for review March 10, 2025 18:42
@rshade rshade requested a review from a team as a code owner March 10, 2025 18:42
@rshade rshade force-pushed the global_rds_perf_insights branch from ce085eb to de64ffe Compare March 10, 2025 18:47
@rshade rshade force-pushed the global_rds_perf_insights branch from de64ffe to e5bfe1c Compare March 12, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
1 participant