Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update RDS Identifier reference in QuickSight data source documentation #41749

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nithishravindra
Copy link
Contributor

@Nithishravindra Nithishravindra commented Mar 8, 2025

…kSight data source documentation

PR #41672: Updated documentation to reflect this addition and provide clarity on how to use the parameter when connecting to specific RDS instances.

Relations

Closes #41672

References

Output from Acceptance Testing

Not applicable, Updated the Docs.

Copy link

github-actions bot commented Mar 8, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/quicksight Issues and PRs that pertain to the quicksight service. size/XS Managed by automation to categorize the size of a PR. labels Mar 8, 2025
@Nithishravindra Nithishravindra marked this pull request as ready for review March 8, 2025 17:22
@Nithishravindra Nithishravindra requested a review from a team as a code owner March 8, 2025 17:22
@Nithishravindra Nithishravindra changed the title Add optional instance identifier parameter for RDS connection in Quic… Docs: Add optional instance identifier parameter for RDS connection in Quic… Mar 8, 2025
@Nithishravindra Nithishravindra changed the title Docs: Add optional instance identifier parameter for RDS connection in Quic… Docs: Update RDS Identifier reference in QuickSight data source documentation Mar 8, 2025
@Nithishravindra Nithishravindra force-pushed the nithish/rds-doc-update branch from b897f27 to 45653ef Compare March 8, 2025 17:53
@@ -264,7 +264,7 @@ To specify data source connection parameters, exactly one of the following sub-o
### rds Argument Reference

* `database` - (Required) The database to which to connect.
* `instance_id` - (Optional) The instance ID to which to connect.
* `instance_id` - (Optional) The instance Identifier to which to connect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't "ID" already shorthand for "identifier"?

I've read the linked issue and still am unclear on the issue with the current description. Could you clarify what the this change is intended to address?

@jar-b jar-b added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/quicksight Issues and PRs that pertain to the quicksight service. size/XS Managed by automation to categorize the size of a PR. waiting-response Maintainers are waiting on response from community or contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: quicksight_data_source
2 participants