Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoflex: Add support for embedded structs #41774

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

autoflex: Add support for embedded structs #41774

wants to merge 26 commits into from
+818 −195

Conversation

gdavison
Copy link
Contributor

Description

terraform-plugin-framework added support for embedded structs in v1.11.0. Add equivalent support to AutoFlex.

gdavison added 25 commits March 10, 2025 14:27
@gdavison
Separates autoFlexConvertStruct into expandStruct and `flattenStr…
87c15b5 
…uct`
@gdavison
Uses correct test
f0191e6
@gdavison
Removes Flattener-specific checks from expandStruct
6037b8b
@gdavison
Removes Expander-specific checks from flattenStruct
fc2575f
@gdavison
Prefer structField.IsExported() to structField.PkgPath == ""
7d2da1d
@gdavison
When expanding, get field index for each field
3af992b
@gdavison
Adds support for expanding structs with embedded struct members
18b6429
@gdavison
Removes unneeded check from flattenStruct
c065e76
@gdavison
When flattening, get field index for each field
2ae5d47
@gdavison
Adds support for flattening structs with embedded struct members
1d46064
@gdavison
Adds StructFields to iterate over all struct fields
0429a9d
@gdavison
Adds ExportedStructFields to iterate over all exported struct fields
0178be7
@gdavison
Uses iterator when flattening struct fields
a04c57c
@gdavison
Uses iterator when expanding struct fields
7cf067d
@gdavison
Uses iterator for mapBlockKey
5bc4682
@gdavison
Uses iterator for setMapBlockKey
749fcec
@gdavison
Uses iterator for flattenPrePopulate
2aa9cd3
@gdavison
Uses iterator for findFieldFuzzy
50b5e0d
@gdavison
Adds support for basetypes.Float32Valuable and `basetypes.Int32Valu…
8cb07df 
…able` to `types.NullValueOf`
@gdavison
Adds support for embedded structs to types.NullOutObjectPtrFields
28f8992
@gdavison
Adds support for embedded structs to types.AttributeTypes[T any]
82ef3aa
@gdavison
Adds support for embedded structs to flex.Calculate
def900d
@gdavison
Prefer reflect.TypeFor[T]() to reflect.TypeOf((*T)(nil)).Elem()
c13046c
@gdavison
Uses range over int
0e6fc22
@gdavison
Updates documentation for StuctFields and ExportedStructFields
2db54ab
@gdavison gdavison requested a review from a team as a code owner March 11, 2025 15:16
@github-actions GitHub Actions
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. linter Pertains to changes to or issues with the various linters. size/XL Managed by automation to categorize the size of a PR. labels Mar 11, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 11, 2025
@ewbankkit
Copy link
Contributor

👍 I think this will be necessary for the per-resource Region override capability with Plugin Framework resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit