Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_vpc_ipv4_cidr_block_association: Support optional import of the ipv4_ipam_pool_id and ipv4_netmask_length attributes #41779

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 11, 2025

Description

Relations

Closes #38873.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVPCIPv4CIDRBlockAssociation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCIPv4CIDRBlockAssociation_ -timeout 360m -vet=off
2025/03/11 16:08:31 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_basic
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_basic
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_disappears
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_disappears
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_ipamBasic
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_ipamBasic
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_ipamBasicExplicitCIDR
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_ipamBasicExplicitCIDR
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_basic
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_ipamBasic
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_ipamBasicExplicitCIDR
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_disappears
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_basic (42.75s)
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_disappears (47.47s)
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_ipamBasicExplicitCIDR (1170.86s)
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_ipamBasic (1174.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1180.674s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Mar 11, 2025
@github-actions github-actions bot added service/ipam Issues and PRs that pertain to the ipam service. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ipam Issues and PRs that pertain to the ipam service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: importing aws_vpc_ipv4_cidr_block_association does not set ipv4 optional values
1 participant