deferred actions: don't plan partial resources during refresh and destroy #36310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfagerlund
previously approved these changes
Jan 14, 2025
There was a problem hiding this comment.
This logic makes sense to me! Also, I tested a combination of this patch and #36311, and it was able to fully recover from an errored destroy plan on subsequent replans.
| @@ -1186,6 +1186,159 @@ func TestApplyDestroy(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| "destroy-partial-state": { | |||
| path: "destroy-corrupted-state", | |||
There was a problem hiding this comment.
🤔 Did you wanna rename the testdata as well?
Co-authored-by: Nick Fagerlund <[email protected]>
liamcervante
added
the
no-changelog-needed
dsa0x
approved these changes
Jan 17, 2025
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a count or foreach attribute is unknown, deferred actions makes Terraform plan a fake resource that represents any "unknown" resources that might appear once the attribute is known.
This PR skips this step for refresh and destroy plans. In both these cases, there are no potential resources that could appear. We are only interested in resources that we know concretely already exist when destroying and refreshing. If a count or foreach attribute is unknown during a refresh or destroy plan, we can just ignore that part of the configuration and refresh or destroy the resources that are already in state.
Target Release
next alpha
CHANGELOG entry
N/A, deferred actions is still in alpha