Add reusable Diagnostic comparer to tfdiags package
#36385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for equality. This uses code originally in the s3 backend. Co-authored-by: Graham Davison <[email protected]>
SarahFrench
force-pushed
the
add-diag-comparer
branch
from
764f075 to
6ec0a29
Compare
SarahFrench
added
the
no-changelog-needed
radeksimko
previously approved these changes
Jan 22, 2025
radeksimko
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #36316 (comment)
This PR moves
diagnosticComparerfrom the s3 backend codebase into thetfdiagspackage so it can be reused elsewhere.Any tests that compare diagnostics have been refactored to use this comparison approach.
Related: hashicorp/hcl#517
Target Release
1.12.x
CHANGELOG entry