plugin: return missing identity schema diagnostics in ReadResource#38683
Open
fallintoplace wants to merge 2 commits into
Open
plugin: return missing identity schema diagnostics in ReadResource#38683fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates the gRPC provider
ReadResourceimplementations for protocol 5 and protocol 6 to return immediately after appending the missing identity schema diagnostic.I also added matching regression tests for both implementations.
Why
If a provider returns
NewIdentityfor a resource type whose schema does not include an identity schema, Terraform currently appends an error diagnostic and then continues intoresSchema.Identity.ImpliedType(). That can panic instead of returning the diagnostic.Testing
go test ./internal/plugin -run 'TestGRPCProvider_ReadResource(_missingIdentitySchema)?$'go test ./internal/plugin6 -run 'TestGRPCProvider_ReadResource(_missingIdentitySchema)?$'go test ./internal/plugingo test ./internal/plugin6