test: Update some tests in command package to use t.Parallel#38688
Draft
SarahFrench wants to merge 1 commit into
Draft
test: Update some tests in command package to use t.Parallel#38688SarahFrench wants to merge 1 commit into
SarahFrench wants to merge 1 commit into
Conversation
Also, replace use of `io/ioutil` in `TestPluginSHA256LockFile_Read`
SarahFrench
added
the
no-changelog-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went looking for places we could use
t.Parallelin thecommandpackage's tests (chasing the high of #38679 😭 ) and realised that the tests there often change the current working directory so mostly are incapable of running in parallel.This PR has a bunch of tests I found that could be made to run in parallel but it has little to no impact on how long the
commandpackage's test suite runs for.Fixes #
Target Release
1.16.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry