command/init: Simplify how we block upgrading the PSS provider during init -upgrade#38690
Open
SarahFrench wants to merge 1 commit into
Open
command/init: Simplify how we block upgrading the PSS provider during init -upgrade#38690SarahFrench wants to merge 1 commit into
init -upgrade#38690SarahFrench wants to merge 1 commit into
Conversation
…pgrade`, now that one download step is specific to the PSS provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #38648 the provider download process was changed:
Previously the two steps were:
The process remains two steps but the new steps are:
Because the first download step is specific to the provider used for state storage we can specifically block that provider being upgraded during init. We block upgrade unless the
-reconfigureflag is supplied. Users see a warning when they perform an uprgade action and PSS is in use.Prior to this, users would get an error if the upgrade process impacted the state store provider, now it's never impacts and warnings remind users to upgrade that provider via another command.
Target Release
1.16.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry