Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to retry vault token retrieval #442

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add ability to retry vault token retrieval #442

wants to merge 3 commits into from

Commits on Apr 3, 2023

  1. Add option to retry Vault Token retrieval 

    Sometimes we might encounter errors when retrieving the Vault token
using a method like JWT. In those cases, the action does not retry the
request today because the got package does not try POST requests by default.

This change adds an option called retryVaultTokenRetrieval that will
add the POST method to the retriable methods got uses. The post method
is not used in any other place in this action, so having the POST method
added to the defaultOptions seems okay for now.
    @wagnerm
    wagnerm committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    05074af View commit details
    Browse the repository at this point in the history

  2. Add a test for Vault token retrieval retries 

    When the retryVaultTokenRetrieval option is set in the action
we will now see HTTP errors when retrieving the Vault token retried.

This adds a test block to test the client.post that is performed
during the token retrieval is retried on an HTTP error, like a 500.
    @wagnerm
    wagnerm committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    5fc6aa3 View commit details
    Browse the repository at this point in the history

  3. Add retryVaultTokenRetrieval input to README

    @wagnerm
    wagnerm committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    c1b8c73 View commit details
    Browse the repository at this point in the history