Update vegeta and expose dns caching #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
requested review from
brewgator and
elliesterner
and removed request for
a team
brewgator
requested review from
a team,
brewgator and
davidadeleon
and removed request for
a team,
brewgator and
elliesterner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 12.10 (and 12.11 for IPv6) Vegeta has added the ability to cache dns so you aren't load testing the DNS server alongside vault. This updates to the latest version therefore and exposes the option within vault benchmark so that it can be utilised.
I'm not the world's best golang programmer - largely this has been a copy/paste exercise for me so please review carefully :)