Add setup_delay to address https://github.com/hashicorp/vault-benchmark/issues/252 #253
+44
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyleesmith
requested review from
JMGoldsmith and
Monkeychip
and removed request for
a team
JMGoldsmith
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
PR to address the issue I raised here: #252
Change replicates the
setup_delayavailable in the PKI sign target and implements this for both kvv1 and kvv2 secret targets.I had an error for the KV V2 target I could add as a comment but did not have the error available for KV. My assumption is the same issue would play out for KV V1 and so would benefit from a sleep too.
Thank you for your consideration and feedback.