-
Notifications
You must be signed in to change notification settings - Fork 0
docs: add semantic-release section #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @drlkf ! I have two things to say about this. First, it is not possible to make the haskell_github_trust Hackage account an uploader account because this is against the Hackage policies. Second, I would like to keep the main README terse and focused on explaining the basic organizational rules. I would prefer to have instructions about automatic release in a separate markdown file which is linked to from the main README file. |
Ah I see, I'll contact the Hackage admin to see if they have a solution for organization accounts.
Will do! |
87f0865
to
fe965a3
Compare
After looking and asking around, I've got the following responses:
If you have another source that states it isn't, could you link it so I can ask which one prevails?
The recommended method is quite similar to what I envisioned, except the secret contains the Hackage token and not username/password, which is readily available to use to all our members, so that threat model isn't mitigated. That being said, I would personally think this is an acceptable risk for making maintainers' life easier; we could also document that drawback somewhere else, but I doubt anyone would find it in an occurrence of such "incident". If those security concerns are not acceptable, I'll just scrap the upload part of |
I've managed to implement automatic
semantic-release
CI that uploads newversions to Hackage automatically in my recently transferred
megaparsec-utils
package, I think it could be useful for other members to be able to do the same.
This new section documents how to make it work for your repository if you want
to use it as well.
EDIT: turns out I had forgotten to remove the
HACKAGE_TOKEN
secret, and since using thehaskell_github_trust
token, it does not have permissions to upload, even candidates. Is it conceivable to converthaskell_github_trust
to an uploader on Hackage? Otherwise, people might have to configure their own personal token in the repositories, which is not ideal. Let me know what you think :)