Skip to content

Conversation

@Bodigrim
Copy link
Collaborator

@Bodigrim Bodigrim commented Jan 7, 2026

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@Bodigrim Bodigrim force-pushed the nuke-Distribution.Compat.MonadFail branch from d75ae00 to ccfe4b1 Compare January 7, 2026 20:25
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might get some complaints from people who use cabal outside our support window (I know there are people who do it), but it's not clear that we should care.

@Bodigrim
Copy link
Collaborator Author

Bodigrim commented Jan 7, 2026

Control.Monad.Fail has been there since base-4.9 / GHC 8.0, which is very long time ago.

@geekosaur
Copy link
Collaborator

Still not very far from our support window, though. (It's kinda wide.)

@Bodigrim
Copy link
Collaborator Author

Bodigrim commented Jan 7, 2026

Anyway, it's not like Distribution.Compat.MonadFail was actually providing any compatibility layer.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jan 8, 2026
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Jan 8, 2026
@Bodigrim Bodigrim force-pushed the nuke-Distribution.Compat.MonadFail branch from ccfe4b1 to 8967e12 Compare January 8, 2026 22:20
@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Jan 10, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2026

Merge Queue Status

✅ The pull request has been merged at 8967e12

This pull request spent 2 hours 1 minute 19 seconds in the queue, including 1 hour 51 minutes 1 second running CI.
The checks were run on draft #11402.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Jan 10, 2026
@mergify mergify bot merged commit a3162da into master Jan 11, 2026
138 checks passed
@mergify mergify bot deleted the nuke-Distribution.Compat.MonadFail branch January 11, 2026 00:23
@mergify mergify bot removed the queued label Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants