Fix: Filter out private internal libraries from package pages #1437
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nikita-volkov <[email protected]>
Co-authored-by: nikita-volkov <[email protected]>
…-visibility Fix: Filter out private internal libraries from package pages
This was referenced Oct 10, 2025
Bodigrim
reviewed
Oct 10, 2025
| in (libName lib, ModSigIndex { modIndex = mod_ix, sigIndex = sig_ix }) | ||
| where | ||
| -- Only show main library or internal libraries with public visibility | ||
| isPublicLibrary lib = libName lib == LMainLibName |
There was a problem hiding this comment.
Is it insufficient to check only libVisibility?
|
|
||
| allCondLibs :: GenericPackageDescription -> [(LibraryName, CondTree ConfVar [Dependency] Library)] | ||
| allCondLibs desc = maybeToList ((LMainLibName,) <$> condLibrary desc) | ||
| allCondLibs desc = filter (isPublicCondLib . snd) $ |
There was a problem hiding this comment.
Isn't this the function responsible for contents on pages like https://hackage.haskell.org/package/tar-0.7.0.0/dependencies? If yes then I think it should continue showing all sublibraries, even internal ones.
| ++ (first LSubLibName <$> condSubLibraries desc) | ||
| where | ||
| -- Check if a conditional library tree contains a public library | ||
| -- We check the root node since visibility is a property of the library itself |
There was a problem hiding this comment.
I don't think this is true: visibility can be a part of CondTree, e. g.,
library foo-internal
if flag(foo)
visibility: public
else
visibility: private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the bug described in #1346.
Should be noted that the patch is generated with AI.