Consistently pass '--keep-temp-files' - #519
Merged
fendor merged 2 commits intoJul 30, 2026
Merged
Conversation
fendor
force-pushed
the
wip/fendor/fix-keep-temp-files-older-cabal
branch
2 times, most recently
from
July 7, 2026 09:37
6e256db to
10762a6
Compare
fendor
force-pushed
the
wip/fendor/fix-keep-temp-files-older-cabal
branch
from
July 7, 2026 14:40
10762a6 to
02aa54b
Compare
fendor
force-pushed
the
wip/fendor/fix-keep-temp-files-older-cabal
branch
3 times, most recently
from
July 29, 2026 11:10
9ca1286 to
6fe58f5
Compare
fendor
changed the title
fendor
force-pushed
the
wip/fendor/fix-keep-temp-files-older-cabal
branch
4 times, most recently
from
July 29, 2026 14:25
2e7d012 to
8e2d89b
Compare
fendor
force-pushed
the
wip/fendor/fix-keep-temp-files-older-cabal
branch
3 times, most recently
from
July 30, 2026 11:54
14426c7 to
d0d5a3e
Compare
Decouples the rendering of the cabal arguments from the computation of the actual arguments. Allows us to have a central location where we decide whether we will use '--keep-temp-files' and other arguments. We pass '--keep-temp-files' to cabal even with single target mode, if the top-level arguments are passed via a response file. Clarify the fallback behaviour if a Cabal version doesn't support '--with-repl'. Additionally, check whether the Cabal version supports '--keep-temp-files' and fall back to single component loading in this case. Thus, in the worst case, when custom packages in the repl closure, we try load it three times. However, still better in the average case. We simply consider the `build-type: Custom` cabal nodes as not recommended. Add lib:Custom test for the current Cabal version. Enable tests that now succeed due to the improved fallback behaviour. Mark tests as expected failures for cabal 3.18.
fendor
force-pushed
the
wip/fendor/fix-keep-temp-files-older-cabal
branch
from
July 30, 2026 12:58
d0d5a3e to
b2cb873
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouples the rendering of the cabal arguments from the computation of
the actual arguments.
Allows us to have a central location where we decide whether we will use
'--keep-temp-files' and other arguments.
Clarify the fallback behaviour if a Cabal version doesn't support
'--with-repl'.
Additionally, check whether the Cabal version supports
'--keep-temp-files' and fall back to single component loading in this
case.
Add lib:Custom test for the current Cabal version.
Enable tests that now succeed due to the improved fallback behaviour.