Skip to content

Remove noncanonical definitions #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhendric wants to merge 1 commit into from
Closed

Remove noncanonical definitions #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion monad-chronicle/src/Control/Monad/Trans/Chronicle.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ instance (Semigroup c, Applicative m) => Applicative (ChronicleT c m) where
ChronicleT f <*> ChronicleT x = ChronicleT (liftA2 (<*>) f x)

instance (Semigroup c, Monad m) => Monad (ChronicleT c m) where
return = ChronicleT . return . return
m >>= k = ChronicleT $
do cx <- runChronicleT m
case cx of
Expand Down
3 changes: 0 additions & 3 deletions semialign/semialign.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ library
default-language: Haskell2010
ghc-options: -Wall -Wno-trustworthy-safe

if impl(ghc >=9.2)
ghc-options: -Wno-noncanonical-monoid-instances

hs-source-dirs: src
exposed-modules:
Data.Align
Expand Down
1 change: 0 additions & 1 deletion semialign/src/Data/Zip.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ instance (Zip f, Semigroup a) => Semigroup (Zippy f a) where

instance (Repeat f, Monoid a) => Monoid (Zippy f a) where
mempty = Zippy $ repeat mempty
mappend (Zippy x) (Zippy y) = Zippy $ zipWith mappend x y
Copy link
Collaborator

@phadej phadej Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is potentially changing behavior, so no, I won't do these. Until GHC starts to treat them as errors, I won't cleanup these warnings.


#ifdef MIN_VERSION_semigroupoids
instance Zip f => Apply (Zippy f) where
Expand Down
Loading