misc/openlane: patch sed to be cross-platform #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proppy
reviewed
Feb 25, 2023
misc/openlane/build.sh
Outdated
| UNAME_OUT="$(uname -s)" | ||
| case "${UNAME_OUT}" in | ||
| Linux*) OS=Linux;; | ||
| <<<<<<< Updated upstream |
There was a problem hiding this comment.
did you meant to commit this?
There was a problem hiding this comment.
I did not! I didn't realize that the upstream changed to use cp rather than git. This makes the patch a bit easier, thanks.
Signed-off-by: Sean Cross <[email protected]>
Add support for klayout to build on macos. This involves some rather egregeous hacks to the Qt build system to work around the fact that Conda builds things using a custom Mac SDK. Signed-off-by: Sean Cross <[email protected]>
|
@xobs sorry for dropping this, do you still want to get that in? |
|
In the intervening time, the openlane patches were merged upstream: The-OpenROAD-Project/OpenLane@45980c8 So we can just drop dbd35f2 from the patchset. |
|
...I've removed that patch from the patchset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sed on BSD and GNU have different behaviour when it comes to the -i flag. They behave the same when a backup file is specified, but differently when no backup is specified.
Rework all invocations in order to get this working on osx.
There is a pending upstream patch: The-OpenROAD-Project/OpenLane#1668