add destroy event and description#12
Merged
tkjaergaard merged 1 commit intoheavyy:masterfrom Mar 5, 2020
Merged
Conversation
Contributor
|
Thank you for PR, and sorry for late merge 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up requiring a destroy event to tell when the underlying component the observer was observing had disappeared because no "leave" event was fired in that scenario.
Example usage scenario:
Here I was wrapping each element from a list of slot contents with your component to be able to tell whether or not they had passed out of view, but the items on menuNodes list (of VNodes) are themselves dynamic meaning the list can change from the outside, which can cause the intersect component and associated contents to disappear without firing a "leave" event.
Admittedly you can fix it this way too: