Crash #8
Open
Crash #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~~~ Compiling 1 file (.ex) warning: variable "opts" is unused (if the variable is not meant to be used, prefix it with an underscore) lib/hedwig_xmpp.ex:109: Hedwig.Adapters.XMPP.handle_info/2 warning: variable "ns_muc_user" does not exist and is being expanded to "ns_muc_user()", please use parentheses to remove the ambiguity or change the variable name lib/hedwig_xmpp.ex:151: Hedwig.Adapters.XMPP.contains_muc_user_namespace?/1 warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name lib/hedwig_xmpp.ex:161: Hedwig.Adapters.XMPP.get_roster/2 warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name lib/hedwig_xmpp.ex:184: Hedwig.Adapters.XMPP.request_all_rooms/2 ~~~
An "x" element without an item field will cause the bot to crash:
~~~
** (FunctionClauseError) no function clause matching in
:fxml.get_subtag/2
(fast_xml)
fxml.erl:175:
:fxml.get_subtag(nil, "item")
(romeo) lib/romeo/xml.ex:45: Romeo.XML.subelement/3
(hedwig_xmpp) lib/hedwig_xmpp.ex:142:
Hedwig.Adapters.XMPP.real_jid_from_room_presence/1
~~~
For example, if a group chat contains a vcard for an avatar:
~~~
{:xmlel, "presence", [{"to", "dest"}, {"from", "source@muc"}, {"id", "1234"}],
[
{:xmlel, "x", [{"xmlns", "vcard-temp:x:update"}],
[{:xmlel, "photo", [], [xmlcdata: "5678"]}]},
{:xmlel, "c",
[
{"xmlns", "http://jabber.org/protocol/caps"},
{"ver", "jiZ985RsHMpIJvoWKUczSnQ5MSs="},
{"node", "http://www.process-one.net/en/ejabberd/"},
{"hash", "sha-1"}
], []}
]}
~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash if a bot joins a group chat with an avatar set in a vcard.